-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: sh2 <[email protected]>
- Loading branch information
Showing
7 changed files
with
174 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| cluster: | ||
| name: mycluster # name of the cluster | ||
| artifact: | ||
| version: v0.2.0-nightly-20230403 | ||
| frontend: | ||
| replicas: 1 | ||
| datanode: | ||
| replicas: 3 | ||
| rpcAddr: 0.0.0.0:14100 | ||
| mysqlAddr: 0.0.0.0:14200 | ||
| httpAddr: 0.0.0.0:14300 | ||
| meta: | ||
| storeAddr: 127.0.0.1:2379 | ||
| serverAddr: 0.0.0.0:3002 | ||
| httpAddr: 0.0.0.0:14001 | ||
|
|
||
| etcd: | ||
| artifact: # invalid artifact | ||
| version: | ||
| local: | ||
|
|
19 changes: 19 additions & 0 deletions
19
pkg/deployer/baremetal/test_data/invalid_hostname_port.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| cluster: | ||
| name: mycluster # name of the cluster | ||
| artifact: | ||
| version: v0.2.0-nightly-20230403 | ||
| frontend: | ||
| replicas: 1 | ||
| datanode: | ||
| replicas: 3 | ||
| rpcAddr: 0.0.0.0:14100 | ||
| mysqlAddr: 0.0.0.0:14200 | ||
| httpAddr: 0.0.0.0:1438000 # invalid port | ||
| meta: | ||
| storeAddr: 127.0.0.1:2379 | ||
| serverAddr: 6870.0.0.0:3243002 # invalid hostname and port | ||
| httpAddr: 0.0.0.0:14001 | ||
|
|
||
| etcd: | ||
| artifact: | ||
| version: v3.5.7 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| cluster: | ||
| name: mycluster # name of the cluster | ||
| artifact: | ||
| version: v0.2.0-nightly-20230403 | ||
| frontend: | ||
| replicas: 0 # invalid replicas | ||
| datanode: | ||
| replicas: -3 # invalid replicas | ||
| rpcAddr: 0.0.0.0:14100 | ||
| mysqlAddr: 0.0.0.0:14200 | ||
| httpAddr: 0.0.0.0:14300 | ||
| meta: | ||
| storeAddr: 127.0.0.1:2379 | ||
| serverAddr: 0.0.0.0:3002 | ||
| httpAddr: 0.0.0.0:14001 | ||
|
|
||
| etcd: | ||
| artifact: | ||
| version: v3.5.7 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| cluster: | ||
| name: mycluster # name of the cluster | ||
| artifact: | ||
| version: v0.2.0-nightly-20230403 | ||
| frontend: | ||
| replicas: 1 | ||
| datanode: | ||
| replicas: 3 | ||
| rpcAddr: 0.0.0.0:14100 | ||
| mysqlAddr: 0.0.0.0:14200 | ||
| httpAddr: 0.0.0.0:14300 | ||
| meta: | ||
| storeAddr: 127.0.0.1:2379 | ||
| serverAddr: 0.0.0.0:3002 | ||
| httpAddr: 0.0.0.0:14001 | ||
|
|
||
| etcd: | ||
| artifact: | ||
| version: v3.5.7 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| // Copyright 2023 Greptime Team | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package baremetal | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "gopkg.in/yaml.v3" | ||
|
|
||
| "github.com/GreptimeTeam/gtctl/pkg/deployer/baremetal/config" | ||
| ) | ||
|
|
||
| func TestValidateConfig(t *testing.T) { | ||
| testCases := []struct { | ||
| name string | ||
| expect bool | ||
| errKey []string | ||
| }{ | ||
| { | ||
| name: "valid_config", | ||
| expect: true, | ||
| }, | ||
| { | ||
| name: "invalid_hostname_port", | ||
| expect: false, | ||
| errKey: []string{ | ||
| "Config.Cluster.MetaSrv.ServerAddr", | ||
| "Config.Cluster.Datanode.HTTPAddr", | ||
| }, | ||
| }, | ||
| { | ||
| name: "invalid_replicas", | ||
| expect: false, | ||
| errKey: []string{ | ||
| "Config.Cluster.Frontend.Replicas", | ||
| "Config.Cluster.Datanode.Replicas", | ||
| }, | ||
| }, | ||
| { | ||
| name: "invalid_artifact", | ||
| expect: false, | ||
| errKey: []string{ | ||
| "Config.Etcd.Artifact.Artifact", | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| var actual config.Config | ||
| if err := loadConfig(fmt.Sprintf("test_data/%s.yaml", tc.name), &actual); err != nil { | ||
| t.Errorf("error while loading %s file: %v", tc.name, err) | ||
| } | ||
|
|
||
| err := ValidateConfig(&actual) | ||
| if tc.expect { | ||
| assert.NoError(t, err) | ||
| } else { | ||
| assert.Error(t, err) | ||
| for _, key := range tc.errKey { | ||
| assert.Contains(t, err.Error(), key) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func loadConfig(path string, ret *config.Config) error { | ||
| configs, err := os.ReadFile(path) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err = yaml.Unmarshal(configs, ret); err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } |