Skip to content

Conversation

@Standing-Man
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • enable datasource support for gcs storage.
  • 🚧 test for export to gcs.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@Standing-Man Standing-Man requested a review from a team as a code owner November 19, 2025 06:18
@github-actions github-actions bot added size/S docs-not-required This change does not impact docs. labels Nov 19, 2025
@WenyXu
Copy link
Member

WenyXu commented Nov 19, 2025

Hi @Standing-Man, thank you for your contribution! However, I’d prefer to use cli::common::ObjectStoreConfig instead, so that we can keep all object storage configurations consistent.

@Standing-Man
Copy link
Contributor Author

Standing-Man commented Nov 19, 2025

Hi @Standing-Man, thank you for your contribution! However, I’d prefer to use cli::common::ObjectStoreConfig instead, so that we can keep all object storage configurations consistent.

You mean there already support Azblob, OSS, and GCS storage? If so, close this PR.

@WenyXu
Copy link
Member

WenyXu commented Nov 20, 2025

Hi @Standing-Man, thank you for your contribution! However, I’d prefer to use cli::common::ObjectStoreConfig instead, so that we can keep all object storage configurations consistent.

You mean there already support Azblob, OSS, and GCS storage? If so, close this PR.

No, the data export and import CLI tools don't support these backends. You can refer to the metadata import CLI to see how cli::common::ObjectStoreConfig supports multiple backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants