Skip to content

Conversation

@MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

sometimes our customer wants to test greptimedb but only has large page size (65536) machine at his hand

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@MichaelScofield MichaelScofield requested a review from a team as a code owner November 14, 2025 06:57
@github-actions github-actions bot added size/XS ci docs-not-required This change does not impact docs. labels Nov 14, 2025
Copilot finished reviewing on behalf of MichaelScofield November 14, 2025 06:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for building GreptimeDB with large page size (65536) to accommodate customers who only have machines with large page sizes available for testing.

  • Added a large-page-size boolean input parameter to the dev-build workflow
  • Configured the build system to set JEMALLOC_SYS_WITH_LG_PAGE=16 environment variable when large page size builds are requested
  • Propagated the parameter through the GitHub Actions workflow and build actions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Makefile Added EXTRA_BUILD_ENVS variable and ASSEMBLED_EXTRA_BUILD_ENV to pass environment variables to docker build commands
.github/workflows/dev-build.yml Added large-page-size workflow input parameter and passed it to build jobs
.github/actions/build-linux-artifacts/action.yml Added large-page-size input and propagated it to build steps
.github/actions/build-greptime-binary/action.yml Added logic to set JEMALLOC_SYS_WITH_LG_PAGE=16 environment variable based on large-page-size input

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengys1996 fengys1996 added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 32168e8 Nov 17, 2025
54 checks passed
@fengys1996 fengys1996 deleted the ci/dev-build-page64k-artifact branch November 17, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci docs-not-required This change does not impact docs. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants