-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bloom-filter): filter rows with segment precision #5286
fix(bloom-filter): filter rows with segment precision #5286
Conversation
Signed-off-by: Zhenchi <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5286 +/- ##
==========================================
- Coverage 84.06% 83.91% -0.16%
==========================================
Files 1199 1200 +1
Lines 225086 225395 +309
==========================================
- Hits 189228 189149 -79
- Misses 35858 36246 +388 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/mito2/src/test_util/version_util.rs: Evaluated as low risk
- src/index/src/bloom_filter.rs: Evaluated as low risk
- src/mito2/src/test_util/sst_util.rs: Evaluated as low risk
- src/index/Cargo.toml: Evaluated as low risk
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5176
#5276
What's changed and what's your intention?
*Builder
tobuilder
modtest_applier
andtest_bloom_filter_applier
PR Checklist
Please convert it to a draft if some of the following conditions are not met.