feat(bloom-filter): bloom filter applier #5220

waynexia · 2024-12-24T04:51:18Z

Signed-off-by: Ruihang Xia [email protected]I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#5176

What's changed and what's your intention?

This patch:

implements basic implement of bloom filter applier
scrapes filters from region scan request for bloom filter index applier
implements cached reader layer for bloom filter index
implements an incremental way to apply bloom filter index after cheaper minmax filter

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.
API changes are backward compatible.
Schema or data changes are backward compatible.

Signed-off-by: Ruihang Xia <[email protected]>

coderabbitai · 2024-12-24T04:51:27Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Signed-off-by: Ruihang Xia <[email protected]>

src/index/src/bloom_filter/applier.rs

Signed-off-by: Ruihang Xia <[email protected]>

evenyag

Approve at
22:33:31 UTC+8
Wednesday, 25 December 2024

Signed-off-by: Ruihang Xia <[email protected]>

src/mito2/src/cache/index/bloom_filter_index.rs

zhongzc · 2024-12-25T15:41:03Z

src/mito2/src/cache.rs

+        let bloom_filter_index_cache = BloomFilterIndexCache::new(
+            self.index_metadata_size,
+            self.index_content_size,
+            self.index_content_page_size,
+        );


I added BloomFilter dedicated cache size configuration in #5237

src/mito2/src/sst/parquet/reader.rs

src/mito2/src/sst/index/bloom_filter/applier.rs

src/mito2/src/cache/index/bloom_filter_index.rs

codecov · 2024-12-25T15:47:01Z

Codecov Report

Attention: Patch coverage is 66.54229% with 269 lines in your changes missing coverage. Please review.

Project coverage is 83.71%. Comparing base (5ba8bd0) to head (c3d7a5c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5220      +/-   ##
==========================================
- Coverage   84.01%   83.71%   -0.30%     
==========================================
  Files        1195     1198       +3     
  Lines      222084   222879     +795     
==========================================
+ Hits       186576   186588      +12     
- Misses      35508    36291     +783

src/index/src/bloom_filter/applier.rs

Signed-off-by: Ruihang Xia <[email protected]>

src/mito2/src/sst/index/bloom_filter/applier.rs

Signed-off-by: Ruihang Xia <[email protected]>

zhongzc

most LGTM

Signed-off-by: Ruihang Xia <[email protected]>

src/index/src/bloom_filter/applier.rs

Signed-off-by: Ruihang Xia <[email protected]>

evenyag

Remember to fix todos in this PR after we merge #5237

waynexia added 4 commits December 19, 2024 19:13

wip

69fedbf

Signed-off-by: Ruihang Xia <[email protected]>

draft search logic

7db0c6c

Signed-off-by: Ruihang Xia <[email protected]>

Merge branch 'main' into bloom-index-applier

1bd8ef0

use defined BloomFilterReader

009bd67

Signed-off-by: Ruihang Xia <[email protected]>

github-actions bot added the docs-not-required This change does not impact docs. label Dec 24, 2024

fix clippy

d2cdbac

Signed-off-by: Ruihang Xia <[email protected]>

zhongzc mentioned this pull request Dec 24, 2024

Add Bloom Filter #5176

Open

19 tasks

evenyag reviewed Dec 24, 2024

View reviewed changes

src/index/src/bloom_filter/applier.rs Outdated Show resolved Hide resolved

waynexia added 2 commits December 25, 2024 17:03

Merge branch 'main' into bloom-index-applier

b5b967c

round the range end

235bb35

Signed-off-by: Ruihang Xia <[email protected]>

evenyag approved these changes Dec 25, 2024

View reviewed changes

waynexia added 3 commits December 25, 2024 23:06

finish index applier

faf3524

Signed-off-by: Ruihang Xia <[email protected]>

integrate applier into mito2 with cache layer

a7111ba

Signed-off-by: Ruihang Xia <[email protected]>

Merge branch 'main' into bloom-index-applier

609d180

Signed-off-by: Ruihang Xia <[email protected]>

waynexia marked this pull request as ready for review December 25, 2024 15:30

waynexia requested review from v0y4g3r, zhongzc and a team as code owners December 25, 2024 15:30

zhongzc reviewed Dec 25, 2024

View reviewed changes

src/mito2/src/sst/parquet/reader.rs Outdated Show resolved Hide resolved

zhongzc reviewed Dec 25, 2024

View reviewed changes

src/mito2/src/sst/index/bloom_filter/applier.rs Outdated Show resolved Hide resolved

zhongzc reviewed Dec 25, 2024

View reviewed changes

src/mito2/src/cache/index/bloom_filter_index.rs Outdated Show resolved Hide resolved

zhongzc reviewed Dec 25, 2024

View reviewed changes

src/index/src/bloom_filter/applier.rs Outdated Show resolved Hide resolved

waynexia added 2 commits December 25, 2024 23:58

fix cache key and add unit test

ebfc3d7

Signed-off-by: Ruihang Xia <[email protected]>

provide bloom filter index size hint

9008990

Signed-off-by: Ruihang Xia <[email protected]>

evenyag reviewed Dec 25, 2024

View reviewed changes

src/mito2/src/sst/index/bloom_filter/applier.rs Outdated Show resolved Hide resolved

src/mito2/src/sst/index/bloom_filter/applier.rs Outdated Show resolved Hide resolved

src/mito2/src/sst/index/bloom_filter/applier.rs Show resolved Hide resolved

waynexia added 2 commits December 26, 2024 00:20

revert BloomFilterReaderImpl::read_vec

29e3367

Signed-off-by: Ruihang Xia <[email protected]>

remove dead code

2d17491

Signed-off-by: Ruihang Xia <[email protected]>

zhongzc approved these changes Dec 25, 2024

View reviewed changes

ignore null on eq

2fcbbe0

Signed-off-by: Ruihang Xia <[email protected]>

evenyag reviewed Dec 25, 2024

View reviewed changes

src/index/src/bloom_filter/applier.rs Outdated Show resolved Hide resolved

add more tests and fix bloom filter logic

7a2be74

Signed-off-by: Ruihang Xia <[email protected]>

waynexia changed the title ~~feat: bloom filter applier~~ feat(bloom-filter): bloom filter applier Dec 25, 2024

evenyag approved these changes Dec 25, 2024

View reviewed changes

Merge branch 'main' into bloom-index-applier

c3d7a5c

waynexia enabled auto-merge December 26, 2024 02:51

waynexia added this pull request to the merge queue Dec 26, 2024

Merged via the queue into GreptimeTeam:main with commit 00ad27d Dec 26, 2024
36 checks passed

waynexia deleted the bloom-index-applier branch December 26, 2024 03:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bloom-filter): bloom filter applier #5220

feat(bloom-filter): bloom filter applier #5220

waynexia commented Dec 24, 2024 •

edited

Loading

coderabbitai bot commented Dec 24, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

evenyag left a comment •

edited

Loading

zhongzc Dec 25, 2024

codecov bot commented Dec 25, 2024 •

edited

Loading

zhongzc left a comment

evenyag left a comment

feat(bloom-filter): bloom filter applier #5220

feat(bloom-filter): bloom filter applier #5220

Conversation

waynexia commented Dec 24, 2024 • edited Loading

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

PR Checklist

coderabbitai bot commented Dec 24, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

evenyag left a comment • edited Loading

Choose a reason for hiding this comment

zhongzc Dec 25, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 25, 2024 • edited Loading

Codecov Report

zhongzc left a comment

Choose a reason for hiding this comment

evenyag left a comment

Choose a reason for hiding this comment

waynexia commented Dec 24, 2024 •

edited

Loading

evenyag left a comment •

edited

Loading

codecov bot commented Dec 25, 2024 •

edited

Loading