feat: init PgElection with candidate registration #5209
+597
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: release advisory lock fix: handle duplicate keys chore: update comments fix: unlock if acquired the lock chore: add TODO and avoid unwrap refactor: check both lock and expire time, add more comments chore: fmt fix: deal with multiple edge cases feat: init PgElection with candidate registration chore: fmt chore: remove
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This was referenced Dec 20, 2024
Closed
fengjiachun
reviewed
Dec 20, 2024
CookiePieWw
force-pushed
the
candidate-reg
branch
from
2d1329d to
d4df24d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5209 +/- ##
==========================================
- Coverage 84.06% 83.76% -0.31%
==========================================
Files 1181 1195 +14
Lines 219334 222096 +2762
==========================================
+ Hits 184390 186044 +1654
- Misses 34944 36052 +1108 |
CookiePieWw
commented
Dec 21, 2024
fengjiachun
reviewed
Dec 23, 2024
WenyXu
reviewed
Dec 23, 2024
Comment on lines
+283
to
+288
| tokio::spawn(async move { | ||
| connection | ||
| .await | ||
| .context(error::PostgresExecutionSnafu) | ||
| .unwrap() | ||
| }); |
There was a problem hiding this comment.
I actually follows the document of tokio_postgres here:
This is one half of what is returned when a new connection is established. It performs the actual IO with the server, and should generally be spawned off onto an executor to run in the background.
Not quite sure what will happen if not spawn a thread with it.
fengjiachun
reviewed
Dec 23, 2024
fengjiachun
approved these changes
Dec 26, 2024
Comment on lines
64
to
82
| if let Some((value, expire_time)) = value.split(LEASE_SEP).collect_tuple() { | ||
| // Given expire_time is in the format 'YYYY-MM-DD HH24:MI:SS.MS' | ||
| let expire_time = match Timestamp::from_str(expire_time, None) { | ||
| Ok(ts) => ts, | ||
| Err(_) => UnexpectedSnafu { | ||
| violated: format!("Invalid timestamp: {}", expire_time), | ||
| } | ||
| .fail()?, | ||
| }; | ||
| Ok((value.to_string(), expire_time)) | ||
| } else { | ||
| UnexpectedSnafu { | ||
| violated: format!( | ||
| "Invalid value {}, expect node info || {} || expire time", | ||
| value, LEASE_SEP | ||
| ), | ||
| } | ||
| .fail() | ||
| } |
There was a problem hiding this comment.
Suggested change
| if let Some((value, expire_time)) = value.split(LEASE_SEP).collect_tuple() { | |
| // Given expire_time is in the format 'YYYY-MM-DD HH24:MI:SS.MS' | |
| let expire_time = match Timestamp::from_str(expire_time, None) { | |
| Ok(ts) => ts, | |
| Err(_) => UnexpectedSnafu { | |
| violated: format!("Invalid timestamp: {}", expire_time), | |
| } | |
| .fail()?, | |
| }; | |
| Ok((value.to_string(), expire_time)) | |
| } else { | |
| UnexpectedSnafu { | |
| violated: format!( | |
| "Invalid value {}, expect node info || {} || expire time", | |
| value, LEASE_SEP | |
| ), | |
| } | |
| .fail() | |
| } | |
| let (value, expire_time) = value | |
| .split(LEASE_SEP) | |
| .collect_tuple() | |
| .context(UnexpectedSnafu { | |
| violated: format!( | |
| "Invalid value {}, expect node info || {} || expire time", | |
| value, LEASE_SEP | |
| ), | |
| })?; | |
| // Given expire_time is in the format 'YYYY-MM-DD HH24:MI:SS.MS' | |
| let expire_time = match Timestamp::from_str(expire_time, None) { | |
| Ok(ts) => ts, | |
| Err(_) => UnexpectedSnafu { | |
| violated: format!("Invalid timestamp: {}", expire_time), | |
| } | |
| .fail()?, | |
| }; | |
| Ok((value.to_string(), expire_time)) |
|
|
||
| use common_time::Timestamp; | ||
| use itertools::Itertools; | ||
| use snafu::{ensure, ResultExt}; |
There was a problem hiding this comment.
Suggested change
| use snafu::{ensure, ResultExt}; | |
| use snafu::{ensure, OptionExt, ResultExt}; |
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl Election for PgElection { |
There was a problem hiding this comment.
nit: the order of impl members differs from the trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As title. Part of #5208
Previous pr #5201
A candidate first write a (candidate_key, node info + expire time) pair into the pg kv backend, and regularly check the expire time.
For
all_candidates, just get all candidate using candidate_key_prefix, and filter the expired value.PR Checklist
Please convert it to a draft if some of the following conditions are not met.