feat(bloom-filter): add memory control for creator

[zhongzc]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#5176

What's changed and what's your intention?

1. Refactor ExternalTempFileProvider to adapt to new index intermediates
2. Extract FinalizedBloomFilterStorage to a new file
3. Complete TODOs in FinalizedBloomFilterStorage:
   1. Implement true global memory control by tracking overall memory usage for creating bloom filters through global memory usage
   2. Implement disk flushing behavior during memory flush using injected ExternalTempFileProvider
   3. Update drain to return FinalizedBloomFilterSegment from both intermediate files and memory as a stream to the upper layer

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 98.90591% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (c33cf59) to head (69511bd).
Report is 22 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5185      +/-   ##
==========================================
- Coverage   84.05%   83.84%   -0.22%     
==========================================
  Files        1175     1183       +8     
  Lines      218970   219706     +736     
==========================================
+ Hits       184065   184203     +138     
- Misses      34905    35503     +598     

Copilot reviewed 6 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (7)

• src/index/src/inverted_index/create/sort.rs: Evaluated as low risk
• src/mito2/src/sst/index/inverted_index/creator/temp_provider.rs: Evaluated as low risk
• src/index/src/lib.rs: Evaluated as low risk
• src/index/src/bloom_filter/creator.rs: Evaluated as low risk
• src/index/src/inverted_index/create/sort/external_sort.rs: Evaluated as low risk
• src/index/src/inverted_index/error.rs: Evaluated as low risk
• src/index/src/bloom_filter/error.rs: Evaluated as low risk

[discord9]

a few questions on bloom filter perf:

• why do we need to set seed explictly to a fixed value for bloom filter? Can we have a random seed for each bloom filter created, and save those seeds to memory/disk too(I see now keeping the same seed is useful for read/write after persisent) But it wouldn't need to be the same across all codebase right? Having a fixed seed also weaken SipHash's protection against DDoS if I understand correctly
• can we switch the hasher of bloom filter to ahash and set the seed randomly?(Which should yield even faster perf gain per author of fastbloom from ~100 ns using SipHash to ~7 ns using ahash(but ahash is not ddos-safe so seed need to be set randomly, which is it's default behavior)

[zhongzc]

a few questions on bloom filter perf:

• why do we need to set seed explictly to a fixed value for bloom filter? Can we have a random seed for each bloom filter created, and save those seeds to memory/disk too(I see now keeping the same seed is useful for read/write after persisent) But it wouldn't need to be the same across all codebase right? Having a fixed seed also weaken SipHash's protection against DDoS if I understand correctly
• can we switch the hasher of bloom filter to ahash and set the seed randomly?(Which should yield even faster perf gain per author of fastbloom from ~100 ns using SipHash to ~7 ns using ahash(but ahash is not ddos-safe so seed need to be set randomly, which is it's default behavior)

Thanks for the suggestion, the calculation of the bloom filter is not a performance bottleneck at the moment, so I'm willing to keep it simple in this regard.

[fengjiachun]

LGTM

[discord9]

LGTM