-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bloom-filter): add basic bloom filter creator (Part 1) #5177
feat(bloom-filter): add basic bloom filter creator (Part 1) #5177
Conversation
Signed-off-by: Zhenchi <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/index/src/bloom_filter/creator.rs:207
- The function 'write_u64_slice' is not covered by tests. Consider adding tests to ensure its correctness.
fn write_u64_slice(buf: &mut Vec<u8>, slice: &[u64]) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5177 +/- ##
==========================================
- Coverage 84.06% 83.80% -0.26%
==========================================
Files 1173 1175 +2
Lines 218590 218982 +392
==========================================
- Hits 183748 183522 -226
- Misses 34842 35460 +618 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: Zhenchi <[email protected]>
77bee2e
to
49c8858
Compare
* feat(bloom-filter): add a simple bloom filter creator (Part 1) Signed-off-by: Zhenchi <[email protected]> * fix: clippy Signed-off-by: Zhenchi <[email protected]> * fix: header Signed-off-by: Zhenchi <[email protected]> * docs: add format comment Signed-off-by: Zhenchi <[email protected]> --------- Signed-off-by: Zhenchi <[email protected]>
* feat(bloom-filter): add a simple bloom filter creator (Part 1) Signed-off-by: Zhenchi <[email protected]> * fix: clippy Signed-off-by: Zhenchi <[email protected]> * fix: header Signed-off-by: Zhenchi <[email protected]> * docs: add format comment Signed-off-by: Zhenchi <[email protected]> --------- Signed-off-by: Zhenchi <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5176
What's changed and what's your intention?
Add basic bloom filter creator implementation (without memory control).
Checklist