Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added checks on creating events and added method for unregister… #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: added checks on creating events and added method for unregister… #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/Map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,11 +1296,27 @@ export default class Map {
}

on(eventName, handler) {
//TODO check event name enum
if (handler) {
log.info('register event:', eventName)
this.events.on(eventName, handler)
const events = Object.values(Map.REGISTERED_EVENTS)
if (!events.includes(eventName)) {
throw new Error(`unrecognisable event name`)
}
if (typeof handler !== 'function') {
throw new Error(`handler isnt't of type function`)
}
log.info('register event:', eventName)
this.events.on(eventName, handler)
}

off(eventName, handler) {
const events = Object.values(Map.REGISTERED_EVENTS)
if (!events.includes(eventName)) {
throw new Error(`unrecognisable event name`)
}
if (typeof handler !== 'function') {
throw new Error(`handler isnt't of type function`)
}
log.info('register event:', eventName)
this.events.off(eventName, handler)
}

selectTree(tree) {
Expand Down