Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace '\n' with '<br/>' for line breaks in wallet.about #1714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: replace '\n' with '<br/>' for line breaks in wallet.about #1714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pages/wallets/[walletid].js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,9 @@ export default function Wallet(props) {
sx={{ mt: [2.5, 5] }}
variant="body2"
dangerouslySetInnerHTML={{
__html: marked.parse(wallet.about || 'NO DATA YET'),
__html: marked.parse(
(wallet.about || 'NO DATA YET').replace(/\\n/g, '<br/>'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankienstan thank you for your work, because the about is in markdown format, so I don't think you should use html tag <br/> here, you should replace with newline \n and give it to marked.parse to generate the content (in html)

BTW, can paste a screenshot of the result?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadiorchen Yea sure ,
Before
before
After
after

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, the
can do the work of breaking new line, but we don't need to do this by ourselves, we just need to fix the extra \\n for the string, and pass it to markdown lib, it will take care of all the work including the newline breaking

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can replacing \n with actual newline characters \n in the wallet.about content before passing it to marked.parse(). This way, marked.parse() will handle the Markdown rendering, including line breaks, as expected.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankienstan yes, exactly

),
}}
/>
<Divider
Expand Down
Loading