fix: redirect 500 error #1696
Merged
fix: redirect 500 error #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadiorchen
reviewed
Jul 25, 2023
There was a problem hiding this comment.
@lichenqin1 I wait for this PR for months :D thank you! please remove the comment above and I will merge it.
src/models/utils.js
Outdated
Comment on lines
233
to
236
| // redirect: { | ||
| // destination: '/500', | ||
| // permanent: false, | ||
| // }, |
There was a problem hiding this comment.
I think commenting out code is not a good practice, to keep the code clean, let's simply remove it.
There was a problem hiding this comment.
I removed the commented code, thanks for the suggestion.
|
@lichenqin1 thank you! |
|
🎉 This PR is included in version 2.6.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1580
Remove redirect for 500 error and use the custom error page to return 500 error. It only works in production due to the design of Next.js, not sure if there is a better way.
Type of change
Screenshots
How Has This Been Tested?
Checklist: