Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance login screen with social login options #373

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

Agastya18
Copy link

@Agastya18 Agastya18 commented Feb 24, 2025

Description

Please provide a clear and concise description of the changes made, including
the purpose and context.

resolves #352


Changes Made

  • Changes in apps folder (specify the app and briefly describe the
    changes):

    • Web
    • Native
  • Changes in packages folder (specify the package and briefly describe
    the changes):

    • Core

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • 📝 Documentation update (changes)

Screenshots

Screenshot 2025-02-24 at 1 12 57 PM

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Comments

(Optional) Add any additional comments or notes for reviewers here.

@Agastya18 Agastya18 requested a review from a team as a code owner February 24, 2025 07:42
@Agastya18
Copy link
Author

@pierrelstan

Copy link
Collaborator

@pierrelstan pierrelstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on these social buttons 🎉 I have a few improvement suggestions:

1- Refactor for Reusability – The social buttons share a similar structure. Could you extract a reusable SocialButton component that accepts props for provider, iconName, onPress? This would make the code more DRY (Don't Repeat Yourself).

2- Library Consistency – I noticed react-native-vector-icons is being used, but @expo/vector-icons is already installed. Any specific reason for this choice?

Copy link
Collaborator

@pierrelstan pierrelstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions & Fixes

1. Avoid Hardcoding Uppercase Titles
Issue: Hardcoding uppercase titles, like "LOG IN WITH GMAIL", reduces flexibility and maintainability.
Suggestion: Apply uppercase styling through CSS or styles, not directly in the text.

2. Rename Styles for Better Clarity and Consistency

Suggestion

socialButtonText → buttonText: Generalizes the name to make it more reusable.
socialButton → button: Simplifies the name while keeping it clear and concise.
forgotPasswordContainer → forgotPasswordSection: "Section" better represents the grouping of elements.
forgotPasswordText → forgotPasswordLabel: "Label" is more suitable for descriptive text.
resetText → resetLink: This reflects its purpose as a clickable link.
orText → dividerText: Makes it clear that this text divides sections.
signupContainer → signupSection: Consistent naming with other section elements.
signupText → signupPrompt: "Prompt" makes it clearer that it’s encouraging action.
signupLink → signupActionLink: "ActionLink" makes it clear that it’s a clickable action.
socialButton → socialButtonContainer: More descriptive and consistent with naming.

@Agastya18
Copy link
Author

hey, i think every thing is good now😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Missing Login Screen Components
3 participants