Get /organizations/{id} change the order for associated planters #243 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadiorchen
reviewed
Nov 7, 2022
| @@ -52,7 +52,7 @@ | |||
| "express-validator": "^6.4.0", | |||
| "joi": "^17.5.0", | |||
| "knex": "^0.95.14", | |||
| "loglevel": "^1.6.8", | |||
| "loglevel": "^1.8.0", | |||
There was a problem hiding this comment.
:) @MundhadHarsh what's the motivation to upgrade this lib
There was a problem hiding this comment.
@dadiorchen it was not importing log from loglevel that's why I had to upgrade
| @@ -26,7 +26,7 @@ function getByFilter( | |||
| function getOrganizationLinks(organization) { | |||
| const links = { | |||
| featured_trees: `/trees?organization_id=${organization.id}&limit=20&offset=0`, | |||
| associated_planters: `/planters?organization_id=${organization.id}&limit=20&offset=0`, | |||
| associated_planters: `/planters?organization_id=${organization.id}&limit=20&offset=0&order_by=about`, | |||
There was a problem hiding this comment.
@MundhadHarsh did you test this feature, I mean, with this order_by parameter, the SQL will try to add corresponding phrase?
There was a problem hiding this comment.
No, I have not tested the feature. I made changes given in the description of #243
|
Should be tested first and confirmed to be working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint: GET /organizations/{id} will return links which includes associated_planter currently, this link is: /planters?organization_id=${organization.id}&limit=20&offset=0 has been changed changed it to associated_planters:/organization_id=${organization.id}&limit=20&offset=0&order_by=about