Add more valid filters for query to /sessions endpoint #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynndp
commented
Nov 15, 2023
Kpoke
requested changes
Dec 14, 2023
| formatKeys(filter) { | ||
| return Object.entries(filter).reduce((obj, [key, val]) => { | ||
| const copy = { ...obj }; | ||
| if (this._wrKeys.includes(key)) { |
There was a problem hiding this comment.
I think we can set the key to wallet_registrations rather than _wrKeys and then having to reformat it
There was a problem hiding this comment.
I'm not sure I understand your advice, can you please clarify?
Those particular keys need to be designated as related to the wallet_registrations table for the query to work. We could do a simple conditional to rename them, but addTableNames could be a utility fn() since we need to do similar transformations for getting the session count.
There was a problem hiding this comment.
I meant just renaming '_wrkeys' to '_walletRegistrationKeys'
Kpoke
approved these changes
Dec 29, 2023
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary change to allow filtering by session in the admin client.
Related to PR in query api: Greenstand/treetracker-query-api#276