Revert "Vulkan: Feedback loop detection and barriers (#7226)"

[KeatonTheBot]

This reverts commit ca59c3f.

Prevents slowdowns in Paper Mario: The Thousand Year Door, the Xenoblade games, and others. Feel free to test and let me know if you get speedups in games where it would normally slow down.

There are known issues with 7000 series AMD cards, so an AMD-only fix would be ideal.

[github-actions]

Download the artifacts for this pull request:

• ryujinx-Release-1.2.0+1f83b6d-linux_arm64
• ryujinx-Release-1.2.0+1f83b6d-linux_arm64-AppImage
• ryujinx-Release-1.2.0+1f83b6d-linux_x64
• ryujinx-Release-1.2.0+1f83b6d-linux_x64-AppImage
• ryujinx-Release-1.2.0+1f83b6d-macos_universal
• ryujinx-Release-1.2.0+1f83b6d-win_x64

GUI-less

• nogui-ryujinx-Release-1.2.0+1f83b6d-linux_arm64
• nogui-ryujinx-Release-1.2.0+1f83b6d-linux_x64
• nogui-ryujinx-Release-1.2.0+1f83b6d-macos_universal
• nogui-ryujinx-Release-1.2.0+1f83b6d-win_x64

Only for Developers

• ryujinx-Debug-1.2.0+1f83b6d-linux_arm64
• ryujinx-Debug-1.2.0+1f83b6d-linux_arm64-AppImage
• nogui-ryujinx-Debug-1.2.0+1f83b6d-linux_arm64
• ryujinx-Debug-1.2.0+1f83b6d-linux_x64
• ryujinx-Debug-1.2.0+1f83b6d-linux_x64-AppImage
• nogui-ryujinx-Debug-1.2.0+1f83b6d-linux_x64
• ryujinx-Debug-1.2.0+1f83b6d-macos_universal
• nogui-ryujinx-Debug-1.2.0+1f83b6d-macos_universal
• ryujinx-Debug-1.2.0+1f83b6d-win_x64
• nogui-ryujinx-Debug-1.2.0+1f83b6d-win_x64

[sunshineinabox]

Thought I should add my two cents to this. This is not a good idea, it would be better to use performance and best practice layer to fix this.

[GreemDev]

Thought I should add my two cents to this. This is not a good idea, it would be better to use performance and best practice layer to fix this.

There's a reason why I haven't merged it yet. We're figuring out a way to keep the behavior when it needs it.

[extherian]

Now that the sparse-jit PR has been merged, would you consider rebasing this PR on the latest Canary release? I didn't see any benefits from either sparse jit nor this Vulkan barrier revert before since I have a weak CPU, but I am curious to see if there will be benefits from having both of them at once.

[KeatonTheBot]

Now that the sparse-jit PR has been merged, would you consider rebasing this PR on the latest Canary release? I didn't see any benefits from either sparse jit nor this Vulkan barrier revert before since I have a weak CPU, but I am curious to see if there will be benefits from having both of them at once.

Done.

[extherian]

The City in Xenoblade went from 40 FPS on both the sparse jit build and barrier revert build individually, to 50 - 55 FPS when both are merged together in this pull request. I guess all that we need to finish it is some way of detecting RDNA3 GPUs to enable vulkan barrier detection for them specifically.