Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default mode for KafkaTransport to non-legacy #20126

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Change default mode for KafkaTransport to non-legacy #20126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cefd18
Change default mode for KafkaTransport to non-legacy
kingzacko1 Aug 8, 2024
a8b0c3a
Add default configuration value change to UPGRADING.md
kingzacko1 Aug 9, 2024
126a2d0
Merge branch 'master' into 19693-kafka-inputs-still-default-to-legacy…
kingzacko1 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/unreleased/issue-19693.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
type="c"
message="Changed default setting for Kafka transports to non-legacy mode."
kingzacko1 marked this conversation as resolved.
Show resolved Hide resolved

issues=["19693"]
5 changes: 2 additions & 3 deletions graylog2-server/src/main/java/org/graylog2/inputs/transports/KafkaTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import com.google.common.util.concurrent.Uninterruptibles;
import com.google.inject.assistedinject.Assisted;
import com.google.inject.assistedinject.AssistedInject;
import jakarta.inject.Named;
import org.apache.kafka.clients.consumer.ConsumerRecord;
import org.apache.kafka.clients.consumer.ConsumerRecords;
import org.apache.kafka.clients.consumer.InvalidOffsetException;
Expand Down Expand Up @@ -66,8 +67,6 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import jakarta.inject.Named;

import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
Expand Down Expand Up @@ -507,7 +506,7 @@ public ConfigurationRequest getRequestedConfiguration() {

cr.addField(new BooleanField(CK_LEGACY,
"Legacy mode",
true,
false,
"Use old ZooKeeper-based consumer API. (Used before Graylog 3.3)",
10
));
Expand Down
Loading