Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See previous migration steps content by making them expendable but not editable #19825

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

See previous migration steps content by making them expendable but not editable #19825

wants to merge 6 commits into from

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Jul 3, 2024 •
edited
Loading

How it works:

  • Previous Steps: clickable, collapsible, expendable but not editable and with a different background color.
  • Current Step: editable but not collapsible/expendable.
  • Next Steps: not editable/clickable/collapsible/expendable.

Motivation and Context

fixes #19803

Screenshots (if appropriate):

Screenshot 2024-07-03 at 18 29 48

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 self-assigned this Jul 3, 2024
@gally47 gally47 requested review from ousmaneo and grotlue July 4, 2024 11:27
moesterheld
moesterheld approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested only the functionality. I really like it! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moesterheld moesterheld moesterheld approved these changes

@vvasylenko vvasylenko Awaiting requested review from vvasylenko

@todvora todvora Awaiting requested review from todvora

@ousmaneo ousmaneo Awaiting requested review from ousmaneo

@grotlue grotlue Awaiting requested review from grotlue

Assignees

@gally47 gally47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

possibility to see previous migration steps content by making them expendable
2 participants
@gally47 @moesterheld