Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add archive, outputs, pipelines, dataWarehouse column to stream overview #19763

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add archive, outputs, pipelines, dataWarehouse column to stream overview #19763

wants to merge 5 commits into from

Conversation

ousmaneo
Copy link
Contributor

This PR adds new columns to stream the overview table to display:

  • Archiving status for the related
  • Outputs
  • Pipelines
  • Data warehouse status

/jpd Graylog2/graylog-plugin-enterprise#7624

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo force-pushed the stream-overview-update-column branch from 58d35f8 to cdc8c3b Compare June 27, 2024 09:26
@ousmaneo ousmaneo marked this pull request as ready for review June 27, 2024 09:27
@ousmaneo ousmaneo requested review from grotlue and gally47 June 27, 2024 15:01
@ousmaneo ousmaneo self-assigned this Jun 27, 2024
gally47
gally47 reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, it works as expected. Code LGTM.
Found one type nitpick.

graylog2-web-interface/src/@types/graylog-web-plugin/index.d.ts
streamDataWarehouseTableElements: {
attributeName: string,
attributes: any,
columnRenderer: any,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we type safe these fields?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gally47 gally47 gally47 left review comments

@grotlue grotlue Awaiting requested review from grotlue

At least 1 approving review is required to merge this pull request.

Assignees

@ousmaneo ousmaneo

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ousmaneo @gally47