Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate datanode CA to cluster config service, refactor handling #19747

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Jun 26, 2024

  • Migrate the CA keystore from its own collection to cluster config service. It significantly simplifies handling, provides support for encrypted values deserialization and keeps the distributed nature of the CA.
  • Adapt CaKeystore and services around this abstraction to the change
  • Remove unused services and classes
  • Simplify and minimize passwords handling for CA
  • Remove unnecessary dependency injection where it doesn't make sense

Motivation and Context

PKI infrastracture in the datanode and server code. cleanup

How Has This Been Tested?

Existing unit and integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora marked this pull request as ready for review July 1, 2024 06:03
@todvora todvora requested a review from moesterheld July 1, 2024 06:03
Base automatically changed from cleanup/legacy-datanode-keystore to master July 1, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants