Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup cache: bubble up error results without modifying #19670

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Lookup cache: bubble up error results without modifying #19670

merged 6 commits into from
Aug 13, 2024

Conversation

patrickmann
Copy link
Contributor

Resolves #19159

Description

Lookup cache needs to distinguish between empty results and error results. The latter should not be altered, in particular the TTL.

How Has This Been Tested?

Unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@patrickmann patrickmann marked this pull request as ready for review June 19, 2024 06:24
@patrickmann patrickmann requested a review from a team June 19, 2024 06:25
@todvora todvora self-requested a review August 12, 2024 13:29
todvora
todvora approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@todvora todvora merged commit ab31c69 into master Aug 13, 2024
6 checks passed
@todvora todvora deleted the lookupCacheErrorHandling branch August 13, 2024 06:59
patrickmann added a commit that referenced this pull request Aug 13, 2024
@patrickmann
Lookup cache: bubble up error results without modifying (#19670)
84379b2 
* bubble up lookup failures

* add unit test

* CL

---------

Co-authored-by: Tomas Dvorak <[email protected]>
(cherry picked from commit ab31c69)
@patrickmann patrickmann mentioned this pull request Aug 13, 2024
Merged
patrickmann added a commit that referenced this pull request Aug 13, 2024
@patrickmann
Lookup cache: bubble up error results without modifying (#19670) (#20167
e38b1fa 
)

* Lookup cache: bubble up error results without modifying (#19670)

* bubble up lookup failures

* add unit test

* CL

---------

Co-authored-by: Tomas Dvorak <[email protected]>
(cherry picked from commit ab31c69)

* update CL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todvora todvora todvora approved these changes

Assignees
No one assigned
Labels
needs-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review error result TTL handling in lookup caches
2 participants
@patrickmann @todvora