Implement feature flag #11070
Merged
Implement feature flag #11070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get feature flag from AppConfig - add Feature component and useFeature hook - this change replace the environement variable based feature flag (#6367)
ousmaneo
force-pushed
the
feature-flag-v1-ui
branch
from
77a1657 to
8067622
Compare
AntonEbel
approved these changes
Jul 30, 2021
edmundoa
suggested changes
Aug 3, 2021
ousmaneo
force-pushed
the
feature-flag-v1-ui
branch
from
22084b9 to
2f719a1
Compare
AntonEbel
reviewed
Aug 9, 2021
edmundoa
reviewed
Aug 13, 2021
edmundoa
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add components and hooks that allow checking for feature flags.
Motivation and Context
This is part of the Feature flag V1 implementation. It uses
featureFlagslist set in the config.js file by the backend as the source of flags. Therefore this replaces the environment variable version used in #6367.ref. #938
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
close Graylog2/graylog-plugin-cloud#938