fix: blend mode preview resetting to Normal when hovering between dropdown entries - #4510
Open
Praashh wants to merge 3 commits into
Open
fix: blend mode preview resetting to Normal when hovering between dropdown entries#4510Praashh wants to merge 3 commits into
Praashh wants to merge 3 commits into
Conversation
…ine changes the blend mode to normal
Praashh
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…and restore control bar left inset
Praashh
changed the title
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2863.
Reason
Previously,
hoverOutEntrywas fired whenever the cursor left any single<LayoutRow>. Because<Separator />elements between sections are not entry rowsFix
By moving the
pointerleavelistener to the parent<LayoutCol>, crossing internal dividers or moving between rows no longer firespointerleave(sincepointerleavedoes not bubble and only fires when exiting the container and all of its child elements).Before
prev.mov
After
after.mov