Skip to content

Fix the 'Separate Subpaths' node dropping a layer's transform when it has no subpaths#4289

Merged
Keavon merged 1 commit into
masterfrom
fix-separate-subpaths-empty-transform
Jun 28, 2026
Merged

Fix the 'Separate Subpaths' node dropping a layer's transform when it has no subpaths#4289
Keavon merged 1 commit into
masterfrom
fix-separate-subpaths-empty-transform

Conversation

@Keavon

@Keavon Keavon commented Jun 28, 2026

Copy link
Copy Markdown
Member

Fixes the bug where the Freehand tool can draw stuff, then delete that stuff with the Path tool, then draw again, resulting in the first point being offset by the Transform node's translation from the starting pointer position.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the separate_subpaths function in vector_nodes.rs to prevent elements with no subpaths from being dropped. By collecting the subpaths first and returning the original row unchanged if the subpaths list is empty, the original element's attributes (such as layer transforms) are preserved downstream. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon merged commit cc465d6 into master Jun 28, 2026
11 checks passed
@Keavon Keavon deleted the fix-separate-subpaths-empty-transform branch June 28, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant