fix breadcrumb connection element ui scaling issue #3620
+19
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
!build |
Member
|
Thanks for the contribution. The visuals should not change. Can you find another way that doesn't change the visuals? |
|
Author
|
Added the required changes please check it looks like this now After fix
Before fix
It looks pretty much the same now. |
Member
|
!build |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord link to issue:- https://discord.com/channels/731730685944922173/881073965047636018/1458467402743287973
This issue can be reproduced by going into the node graph and then clicking on a sub element.
The issue lies on the Breadcrumb menu showing the user where they currently are in the graph
such as Document->Layer.
The issue arises due to non integer scaling on certain scales.
I have taken a few screenshots before my fix to show this.
Before
Zoom (110%)
Zoom (150%)
I narrowed it down the issue to
frontend/src/components/widgets/buttons/BreadcrumbTrailButtons.sveltespecifically in the way it was drawn. The
.text-button, and i seem to understand its a block element, and whenever the scale changes (like 110%) the browser might possibly calculate the dimensions of the border(which seems to be the way the arrow was drawn) and make some rounding error which seems to misalign the ui as seen in the Before pictures.I wrote a fix by drawing the text button using clip-path so it stays stable across all ui scales as its recalculated perfectly and does not seem to cause any misalignment.
After
Zoom (110%)
Zoom(150%)
The ui might have been altered slightly visually but the misalignment issue does not seem to be there anymore