Skip to content

Add combined parameter to box_warp function #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathurojus wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −2
Open

Add combined parameter to box_warp function #3553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d80eb4
Add combined parameter to box_warp function
mathurojus Dec 31, 2025
742d0e8
Implement combined parameter logic in box_warp function
mathurojus Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions node-graph/nodes/vector/src/vector_nodes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,10 +785,26 @@ async fn extrude(_: impl Ctx, mut source: Table<Vector>, direction: DVec2, joini
}

#[node_macro::node(category("Vector: Modifier"), path(core_types::vector))]
async fn box_warp(_: impl Ctx, content: Table<Vector>, #[expose] rectangle: Table<Vector>) -> Table<Vector> {
async fn box_warp(_: impl Ctx, content: Table<Vector>, #[expose] rectangle: Table<Vector>, #[expose] combined: bool) -> Table<Vector> {
let Some((target, target_transform)) = rectangle.get(0).map(|rect| (rect.element, rect.transform)) else {
return content;
};

// Compute combined bounding box if needed
let combined_bbox = if combined {
content.iter().fold(None, |acc: Option<[DVec2; 2]>, row| {
let bbox = row.element.bounding_box_with_transform(row.transform);
match (acc, bbox) {
(None, Some(bbox)) => Some(bbox),
(Some([min, max]), Some([bbox_min, bbox_max])) => {
Some([min.min(bbox_min), max.max(bbox_max)])
}
(acc, None) => acc,
}
})
} else {
None
};

content
.into_iter()
Expand All @@ -797,7 +813,7 @@ async fn box_warp(_: impl Ctx, content: Table<Vector>, #[expose] rectangle: Tabl
let vector = row.element;

// Get the bounding box of the source vector geometry
let source_bbox = vector.bounding_box_with_transform(transform).unwrap_or([DVec2::ZERO, DVec2::ONE]);
let source_bbox = combined_bbox.unwrap_or_else(|| vector.bounding_box_with_transform(transform).unwrap_or([DVec2::ZERO, DVec2::ONE]));

// Extract first 4 points from target shape to form the quadrilateral
// Apply the target's transform to get points in world space
Expand Down