Skip to content

Ignore out-of-range mouse button values using from_bits_truncate #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrueDoctor merged 3 commits into from
Jan 11, 2026
Merged

Ignore out-of-range mouse button values using from_bits_truncate #3541

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7187f08
fix: ignore out-of-range mouse button values using from_bits_truncate
Ayush2k02 Dec 29, 2025
28ad645
Apply suggestion from @TrueDoctor
TrueDoctor Jan 11, 2026
fdde1a8
Fix formatting
TrueDoctor Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion editor/src/messages/input_mapper/utility_types/input_mouse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ pub struct EditorMouseState {

impl EditorMouseState {
pub fn from_keys_and_editor_position(keys: u8, editor_position: EditorPosition) -> Self {
let mouse_keys = MouseKeys::from_bits(keys).expect("Invalid decoding of MouseKeys");
// TODO: Some graphic tablets send key codes not mentioned in the spec. In the future we would like to support these as well.
let mouse_keys = MouseKeys::from_bits_truncate(keys);

Self {
editor_position,
Expand Down
Loading