-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line tool drawing with start and end points #2178
base: master
Are you sure you want to change the base?
Conversation
Welcome back! In regards to your quoted text, how does that relate to the current situation after your rollback? What is the status of the code as you've committed it presently? |
The current code implements the required functionality in its most basic form, it draws a line based on starting and end points. Although preview drawing of line and shift ctrl functionalities are lost which i need help introducing again. You can see this in the issues tab where I presented a screen recording of it. The code is (mostlyyyyy) in the same state as it was when I uploaded that video. The rollback I referred to was from a solution to a node problem I was having where I tried to use Rc/Arc to reference the node instead of passing it directly into nodes vector. It had its own issues so I came back to my first draft. Also regarding the review I added is actually a bug for other tools which I recently introduced while trying to implement a preview myself. Its fixed now. |
Closes #2090
This isnt a proper fix for the issue but a starting point for it.