Repository navigation
Make the Select tool re-select initially selected layers upon pressing Shift during box selection - #2171
Closed
0SlowPoke0 wants to merge 7 commits into
Closed
Make the Select tool re-select initially selected layers upon pressing Shift during box selection#21710SlowPoke0 wants to merge 7 commits into
0SlowPoke0 wants to merge 7 commits into
Conversation
0SlowPoke0
force-pushed
the
shift_select_previous
branch
2 times, most recently
from
January 1, 2025 12:53
0dd824b to
3cf3cdb
Compare
Member
|
!build |
|
Member
|
We'll want the introduced Shift functionality to be on a held, not toggle, basis. |
Member
|
!build |
|
Member
|
!build |
|
0SlowPoke0
marked this pull request as ready for review
January 10, 2025 16:35
Keavon
force-pushed
the
shift_select_previous
branch
from
January 10, 2025 21:38
7e2d510 to
2981512
Compare
Member
|
!build |
|
Keavon
changed the title
Keavon
approved these changes
Jan 13, 2025
Keavon
force-pushed
the
shift_select_previous
branch
from
January 13, 2025 02:25
2981512 to
9f865c4
Compare
Member
|
!build |
|
Member
|
See my comment in Discord for an edge case. Marking as draft for the moment. |
Keavon
marked this pull request as draft
January 13, 2025 02:49
0SlowPoke0
force-pushed
the
shift_select_previous
branch
4 times, most recently
from
January 13, 2025 17:07
d2c7bf0 to
8d6d475
Compare
Keavon
force-pushed
the
shift_select_previous
branch
from
January 13, 2025 19:51
8d6d475 to
e416ccb
Compare
Member
|
!build |
Keavon
marked this pull request as ready for review
January 13, 2025 21:26
|
Keavon
marked this pull request as draft
January 13, 2025 21:28
0SlowPoke0
marked this pull request as ready for review
January 14, 2025 02:12
Keavon
marked this pull request as draft
January 14, 2025 04:08
Keavon
force-pushed
the
master
branch
2 times, most recently
from
January 18, 2025 00:03
7465fad to
ab724d8
Compare
Member
|
It would be good if we could return to this, or potentially de-scope the Shift key secondary actuation aspect if that helps simplify it to succeed in all the edge cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2279 by improving the Select tool as discussed in discord. Path tool is still needed.