Fix VPN app update disabling always on and leak blocking#382
Merged
thestinger merged 1 commit intoJun 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a VPN app is updated and a user with that app set as the always-on VPN is started but not unlocked, then that app is removed as the always-on VPN for that user which in turn also removes leak blocking.
To reproduce this, one can install a VPN, set it as always on, restart the phone and update the package using adb install. After this process, the app will no longer have always on set. Alternatively, install the same VPN app in multiple users, set it as always on in the second user, restart the second user and then update the app in the primary user.
The issue is that
Vpn.startAlwaysOnVpn()verifies that the package contains a VpnService, and this check doesn't work properly in BFU (unless the VpnService is marked as directBootAware).Closes: GrapheneOS/os-issue-tracker#8023