Skip to content

Debounce details screen navigation to prevent crash #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xhon-pelushi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Debounce details screen navigation to prevent crash #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/src/main/java/app/grapheneos/apps/ui/PackageListAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package app.grapheneos.apps.ui

import android.annotation.SuppressLint
import android.os.SystemClock
import android.view.ViewGroup
import androidx.core.view.ViewCompat
import androidx.core.view.WindowInsetsCompat
Expand Down Expand Up @@ -112,8 +113,21 @@ fun PackageListItemBinding.set(fragment: Fragment, pkgState: PackageState) {
root.tag = pkgState
}

// Debounces navigation to the details screen: without this, tapping a list item (e.g. a
// dependency shown within the details screen itself) repeatedly in quick succession queues up
// fragment transactions faster than their enter transitions can finish, which can crash
// FragmentManager (see https://github.com/GrapheneOS/AppStore/issues/436).
private const val DETAILS_NAVIGATION_DEBOUNCE_MS = 500L
private var lastDetailsNavigationTime = 0L

fun PackageListItemBinding.setOnClickListener(fragment: Fragment) {
root.setOnClickListener { root ->
val now = SystemClock.elapsedRealtime()
if (now - lastDetailsNavigationTime < DETAILS_NAVIGATION_DEBOUNCE_MS) {
return@setOnClickListener
}
lastDetailsNavigationTime = now

val packageState = root.tag as PackageState
val pkgName = packageState.pkgName
fragment.findNavController().navigate(NavGraphDirections.actionToDetailsScreen(pkgName))
Expand Down