BREAKING: Converts to Swift Concurrency #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulofaria
previously approved these changes
Jun 24, 2025
adam-fowler
reviewed
Jun 24, 2025
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
b6afc7d to
cd2009d
Compare
This removes the NIO dependency. It is breaking because it removes all Swift NIO-isms that were present in the public APIs (like EventLoopFuture and EventLoopGroup argument/return types).
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
cd2009d to
cf9f195
Compare
NeedleInAJayStack
changed the title
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
cf9f195 to
ac8c049
Compare
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
ac8c049 to
9ec313a
Compare
The intent is to replace it with swift-distributed-tracing integration.
This resolves the race condition caused by the inbox counts and the event delivery. If event delivery happens before the subsequent publish increments the inbox counts, then the counts will be lower than expected. Resolved by just not asking for inbox counts, since they aren't relevant to the test.
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
6a3bb81 to
1bc642c
Compare
This was causing test hangs on macOS
|
Hey @adam-fowler & @paulofaria - I managed to get the tests passing, and I think this is ready for you guys to look again. Could you give it a pass on my changes following your comments? |
paulofaria
reviewed
Jul 3, 2025
adam-fowler
reviewed
Jul 4, 2025
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
db77ae5 to
c398797
Compare
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
c398797 to
34268d3
Compare
paulofaria
previously approved these changes
Jul 14, 2025
NeedleInAJayStack
force-pushed
the
feat/swift-concurrency
branch
from
4094273 to
e1c66d9
Compare
|
@paulofaria Okay, I'm feeling pretty confident in this - do you mind taking a look at the final changes and approving (again)? Thanks for the review!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the NIO dependency. It is breaking because it removes all Swift NIO-isms that were present in the public APIs (like EventLoopFuture and EventLoopGroup argument/return types).