Properly serialize/deserialize mongoose documents to/from cache #109
+136
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorensr Just following up here. I can add unit tests and make changes, but wanted to first get your input on the high level approach before spending additional time. |
|
Hey @doronrk, sorry for the wait—code looks good, tests sound good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lorensr How does this look to you? This is fully backwards compatible. Code expecting mongoose documents to be returned from the
find...methods will not break.toObjectis called only before serializing to the cache, not on the return value. When a document is deserialized from the cache,mongoose.Model.hydrateis called on the result as well because the API expects a mongoose document in this case.Happy to address any feedback in the approach, let me know.