Port newer color readability functions from TinyColor#6681
Open
DavidHarvey wants to merge 2 commits intoGrapesJS:devfrom
Open
Port newer color readability functions from TinyColor#6681DavidHarvey wants to merge 2 commits intoGrapesJS:devfrom
DavidHarvey wants to merge 2 commits intoGrapesJS:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "port" of TinyColor is either old, or modified, such that readability methods return unexpected results. This simply ports the latest readability methods (and necessary complementary methods, like
getLuminance).As an example, take the background color #0066cc and the foreground color #fff. This combination passes all WCAG contrast checks, except for AAA on normal sized text (See: https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=0066CC)
Before:
After: