Prevent infinite request loop with srcset in image. Closes #6332

GrapesJS · Dec 4, 2024 · 2bd968e · 2bd968e
1 parent 0db6729
commit 2bd968e
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/core/src/dom_components/view/ComponentImageView.ts b/packages/core/src/dom_components/view/ComponentImageView.ts
@@ -95,9 +95,12 @@ export default class ComponentImageView<TComp extends ComponentImage = Component
   }
 
   onError() {
-    const fallback = this.model.getSrcResult({ fallback: true });
+    const { model, el } = this;
+    const fallback = model.getSrcResult({ fallback: true });
     if (fallback) {
-      this.el.src = fallback;
+      // Remove srcset to prevent error loop on src update #6332
+      if (el.srcset) el.srcset = '';
+      el.src = fallback;
     }
   }