Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python < 3.6 #191

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tiran
Copy link

@tiran tiran commented Oct 6, 2021

Signed-off-by: Christian Heimes [email protected]

Signed-off-by: Christian Heimes <[email protected]>
@GrahamDumpleton
Copy link
Owner

Why wouldn't I skip this and go straight to:

@tiran
Copy link
Author

tiran commented Oct 6, 2021

This PR is pretty much safe, does not introduce any nasty C bugs, and removes all Python 2 related quirks.

PR #187 doesn't remove all Python 2 code. There is also a possibility that it introduces C bugs or ref leaks. It needs a thorough review.

@tiran tiran marked this pull request as ready for review October 9, 2021 10:24
Comment on lines -19 to -20
Programming Language :: Python :: 2
Programming Language :: Python :: 2.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you drop support for Python 2.7 explicitly, I guess it's perfectly valid to release it as 1.14.0 (contrary to what I originally wrote in #189 (comment)). I realized that pip will not install 1.14.0 in a Python 2.7 environment if the support is dropped explicitly.

Thanks a lot for this change ❤ - I fully support it (but you do not have to listen to a n00b like me 😉)

@n1ngu
Copy link

n1ngu commented Oct 15, 2021

Such PR essentially removing this amount of compatibility boilerplate and still passing the test suite for python 3.6-3.10 and pypy can only be approved! Looks Very Good To Me.

I also vouch to integrate this separately from #187 for the sake of the VCS sanity.

@zevaryx
Copy link

zevaryx commented Mar 10, 2022

Taking a look at this, and testing against Python 3.11a6, wrapt fails to install on Python 3.11 due to setuptools.formatargspec being removed. However, since this PR drops support for Python 3.5 and lower, it should be replaced with setuptools.signature as recommended in the release notes for Python 3.11

@GrahamDumpleton
Copy link
Owner

GrahamDumpleton commented Mar 10, 2022

Version 1.14.0 of wrapt deals with Python 3.11 changes. This PR would need to be rebased against that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants