Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the publication name to be altered from the extension #4

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Allow the publication name to be altered from the extension #4

merged 4 commits into from
Mar 30, 2024

Conversation

StylianosGakis
Copy link
Contributor

Context:
#3

@StylianosGakis StylianosGakis mentioned this pull request Mar 19, 2024
Closed
@StylianosGakis
Copy link
Contributor Author

StylianosGakis commented Mar 30, 2024 •
edited
Loading

Published locally with the current state of the project, after the commit 9a67540
And I got this result (with the new default behavior). So this seems to work very well now.
image

I tried to fix the last comment you had in the PR as well. Let me know if I didn't do it as it should be.

@martinbonnin
Copy link
Member

Sweet ! Thanks for the contribution ❤️ , I'll do a release in a bit.

@martinbonnin martinbonnin merged commit 0b27677 into GradleUp:main Mar 30, 2024
1 check passed
@martinbonnin
Copy link
Member

martinbonnin commented Mar 30, 2024 •
edited
Loading

Version is building here..
.. And it's released 🎉 . Should be on MavenCentral shrotly.

@StylianosGakis StylianosGakis deleted the stylianos/renamable-publication-name branch April 2, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StylianosGakis @martinbonnin