Local fix for #148 #180
Merged
Local fix for #148 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore unused arguments to update_ingredient_row (ingkey) GourmandRecipeManager#148 Signed-off-by: Eliot Blennerhassett <[email protected]>
GtkEntryCompletion should use set_text_column (doesn't have set_entry_text_column, even when spelled correctly) Signed-off-by: Eliot Blennerhassett <[email protected]>
FriedrichFroebel
merged commit 4e3fda0
into
GourmandRecipeManager:main
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Localised fix for #148 (avoids a traceback). Another issue suggests ingkey should be refactored out of existence,
but that is a much bigger job.
Also fixes a traceback when loading shopping editor plugin (don't know an issue number for this one)
How Has This Been Tested?
Run gourmand, test editing of a recipe ingredient.
Screenshots (if appropriate):
Types of changes