Skip to content

Conversation

Katharsas
Copy link
Contributor

So i basically have not better way to guess which game version i might be dealing with, so i made this change to be able to get ZenKits opinion on this^^

@lmichaelis lmichaelis self-requested a review October 9, 2025 16:48
@lmichaelis lmichaelis self-assigned this Oct 9, 2025
@lmichaelis lmichaelis added the enhancement New feature or request label Oct 9, 2025
@lmichaelis
Copy link
Member

Heyo, thanks for making a PR! I'll let the CI run but it looks good :)

@Katharsas
Copy link
Contributor Author

CI seems to be broken a bit in general, i don't think it has much to do with my changes^^
Btw. trying to run tests on windows results in

PS C:\Users\Jan\Repositories\Renderer\ZenKit\out\build\x64-Debug> .\test-zenkit.exe
[doctest] doctest version is "2.4.12"
[doctest] run with "--help" for options
===============================================================================
C:\Users\Jan\Repositories\Renderer\ZenKit\tests\TestCutsceneLibrary.cc(39):
TEST SUITE: CutsceneLibrary
TEST CASE:  CutsceneLibrary.load(GOTHIC1)

C:\Users\Jan\Repositories\Renderer\ZenKit\tests\TestCutsceneLibrary.cc(39): ERROR: test case THREW exception: Failed to open ./samples/ou.proprietary.bin

===============================================================================
C:\Users\Jan\Repositories\Renderer\ZenKit\tests\TestCutsceneLibrary.cc(46):
TEST SUITE: CutsceneLibrary
TEST CASE:  CutsceneLibrary.dump(GOTHIC1)

C:\Users\Jan\Repositories\Renderer\ZenKit\tests\TestCutsceneLibrary.cc(46): ERROR: test case THREW exception: Failed to open ./samples/ou.proprietary.bin

===============================================================================
C:\Users\Jan\Repositories\Renderer\ZenKit\tests\TestDaedalusScript.cc(14):
TEST SUITE: DaedalusScript
TEST CASE:  DaedalusScript.load

C:\Users\Jan\Repositories\Renderer\ZenKit\tests\TestDaedalusScript.cc(14): ERROR: test case THREW exception: Failed to open ./samples/menu.proprietary.dat

minkernel\crts\ucrt\src\appcrt\time\wcsftime.cpp(1163) : Assertion failed: false

@lmichaelis lmichaelis merged commit 132ea8d into GothicKit:main Oct 19, 2025
8 of 12 checks passed
@lmichaelis
Copy link
Member

Yea those failures aren't caused by this change :) Merged.

@Katharsas Katharsas deleted the feat/return-game-version branch October 19, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants