Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

djotaku
Copy link
Contributor

@djotaku djotaku commented Nov 28, 2024

I saw that you were looking at using a Github workflow to publish the package. This is based on a workflow that I use for one of my Python packages that's controlled by Poetry. It would publish the package whenever you create a Github release.

This workflow would require you to create a secret for the repo called PYPI_TOKEN that would use a token (rather than username/password) to publish the package to your PyPi account.

add workflow for publishing via poetry
removed the item that would be covered by this PR
@djmitche djmitche requested a review from illya-laifu November 28, 2024 01:25
@illya-laifu
Copy link
Collaborator

While this looks great for a purely python project, this is not going to work with the PyO3 - since it's built using maturin and the poetry is purely for the pytest and maturin dependencies/executables.

pyproject.toml file got auto generated by the maturin init, without poetry integration, I just used poetry for the dependencies because it was convenient.

Problem is - this will not compile without cargo and rust, but this should be solvable via an apt-get install rust followed by a maturin publish. My mistake, I should have added build instructions to the README

The workflow that was auto generated was removed, but you can still see it under 51bb978. I removed it purely because it was a lot, and I wasn't sure what exactly was needed at the time. If you are willing - feel free to look over the commit, and see if anything from there is useful.

I however will update the README with clear build instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants