gitlab: Begin migrating owned to default to True #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
force-pushed
the
gitlab-owned-default-true
branch
from
bd89304
to
b02d272
Compare
Per discussion in GothenburgBitFactory#986, this has a few benefits: - Our example configuration will actually be valid since it uses gitlab.com as a host but does not define a filter. - More similar default behavior to other services, such as github. - Hopefully less confusion about the filtering requirements to avoid rate-banning and fewer bug reports caused by rate bans. We start off by implementing the first step, which is to raise a warning if 'owned' is undefined. The remainder of the migration plan is in the validator docstring.
ryneeverett
force-pushed
the
gitlab-owned-default-true
branch
from
b02d272
to
7a3367e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #986, this has a few benefits:
We start off by implementing the first step, which is to raise a warning if 'owned' is undefined. The remainder of the migration plan is in the validator docstring.