Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get neglected tests to pass in Chrome #436

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cratonica
Copy link

I was unable to get the tests to all pass in FireFox due to Polymer/polymer#4146, but this at-least gets them passing in Chrome.

This will give me some confidence that I didn't break anything after I run it through Modulizer.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@cratonica
Copy link
Author

I'm a Googler, so I don't need to sign the CLA.

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants