Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New charts #144

Closed
wants to merge 1 commit into from
Closed

New charts #144

wants to merge 1 commit into from

Conversation

fmauNeko
Copy link
Contributor

@fmauNeko fmauNeko commented Aug 8, 2016

Hello again,
After adding the calendar, I thought "Why not add them all !".

So here it is, I added them all, sorted them alphabetically, and took away the trailing commas :)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

CLAs look good, thanks!

Also removed trailing commas
@fmauNeko
Copy link
Contributor Author

fmauNeko commented Aug 8, 2016

Apologies, I may have flooded travis a little, rebasing is hard.

@wesalvaro
Copy link
Member

So, I forgot to point out in your other PR that you were missing a demo. =
That's been the limiting factor on adding the chart types. You can check out #94 for one issue. It'd be good to have demos to access issues like the one mentioned for the annotation chart.
Potentially, thought, we could use a dom-repeat to create the demos?
What do you think?

@fmauNeko
Copy link
Contributor Author

I think most of those charts require some specific data sets.
I'll work on some demos as soon as possible !

@wesalvaro
Copy link
Member

Sorry! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants