deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support #4418

armsargis · 2025-09-22T13:11:04Z

Updated org.ow2.asm:asm to version 9.8 for java 25 support and replace deprecated getNextTarEntry with getNextEntry

BEGIN_COMMIT_OVERRIDE
deps: update org.ow2.asm:asm to version 9.8 for java 25 support
END_COMMIT_OVERRIDE

Fixes #4417🛠️

…`org.ow2.asm:asm` to version 9.8.

gemini-code-assist · 2025-09-22T13:11:22Z

Summary of Changes

Hello @armsargis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining compatibility and modernizing API usage within the project. It updates a core dependency, org.ow2.asm:asm, to support upcoming Java versions, specifically Java 25. Concurrently, it addresses API deprecation by replacing an outdated method for reading TAR entries with its current equivalent across several files, ensuring the codebase remains up-to-date and free of warnings.

Highlights

Dependency Update: The org.ow2.asm:asm library has been updated from version 9.5 to 9.8 to ensure compatibility with Java 25.
Deprecated API Replacement: All instances of the deprecated getNextTarEntry() method from TarArchiveInputStream have been replaced with the modern getNextEntry() method across the codebase.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist · 2025-09-22T13:12:08Z

Summary of Changes

Hello @armsargis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintaining compatibility and modernizing API usage. It updates a core dependency, org.ow2.asm:asm, to support upcoming Java versions, specifically Java 25. Concurrently, it addresses API deprecation by replacing an outdated method for reading TAR archive entries with its current equivalent, ensuring the codebase remains up-to-date and avoids potential issues with future library versions.

Highlights

Dependency Update: The org.ow2.asm:asm library has been updated from version 9.5 to 9.8 to ensure compatibility with Java 25.
Deprecated API Replacement: Instances of the deprecated getNextTarEntry() method from TarArchiveInputStream have been replaced with the modern getNextEntry() method across several files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist · 2025-09-22T13:12:34Z

Summary of Changes

Hello @armsargis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures the project remains compatible with the latest Java advancements by updating a critical bytecode manipulation dependency, org.ow2.asm:asm, to version 9.8 for Java 25 support. Additionally, it addresses API deprecations by replacing the getNextTarEntry() method with getNextEntry() in TarArchiveInputStream usage throughout the codebase, leading to cleaner and more up-to-date code.

Highlights

Dependency Update: The org.ow2.asm:asm library has been updated from version 9.5 to 9.8 to provide essential support for Java 25.
Deprecated API Replacement: All instances of the deprecated getNextTarEntry() method from TarArchiveInputStream have been replaced with the modern getNextEntry() method across several files, improving code hygiene and maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the org.ow2.asm:asm dependency to version 9.8 to add support for Java 25. It also replaces the deprecated getNextTarEntry() method with getNextEntry() across the codebase. The changes are correct and improve the code by using an up-to-date API. I have one suggestion to improve code consistency and readability.

gemini-code-assist · 2025-09-22T13:12:37Z

jib-core/src/main/java/com/google/cloud/tools/jib/tar/TarExtractor.java

+      for (TarArchiveEntry entry = tarArchiveInputStream.getNextEntry();
          entry != null;
-          entry = tarArchiveInputStream.getNextTarEntry()) {
+          entry = tarArchiveInputStream.getNextEntry()) {


For consistency with other parts of the codebase and for better readability, this for loop can be converted to a while loop. The while ((entry = ...getNextEntry()) != null) pattern is more idiomatic for iterating through archive entries.

TarArchiveEntry entry; while ((entry = tarArchiveInputStream.getNextEntry()) != null) {

gemini-code-assist

Code Review

This pull request correctly updates the org.ow2.asm:asm dependency to version 9.8, which adds support for Java 25. It also replaces the deprecated getNextTarEntry method with getNextEntry across the codebase. The changes are straightforward and well-executed. I have one minor suggestion to improve code consistency.

gemini-code-assist · 2025-09-22T13:13:32Z

jib-core/src/main/java/com/google/cloud/tools/jib/tar/TarExtractor.java

+      for (TarArchiveEntry entry = tarArchiveInputStream.getNextEntry();
          entry != null;
-          entry = tarArchiveInputStream.getNextTarEntry()) {
+          entry = tarArchiveInputStream.getNextEntry()) {


For better readability and consistency with other parts of the codebase (e.g., ReproducibleImageTest.java), consider refactoring this for loop into a while loop. The while ((entry = ...)) {} pattern is more idiomatic in Java for this type of iteration.

TarArchiveEntry entry; while ((entry = tarArchiveInputStream.getNextEntry()) != null) {

gemini-code-assist

Code Review

This pull request updates the ASM dependency to version 9.8 to add support for Java 25 and replaces the deprecated getNextTarEntry method with getNextEntry. The changes are correct and follow the pull request's intent. I have one suggestion in TarExtractor.java to refactor a loop for better readability and consistency with the rest of the codebase.

gemini-code-assist · 2025-09-22T13:13:37Z

jib-core/src/main/java/com/google/cloud/tools/jib/tar/TarExtractor.java

+      for (TarArchiveEntry entry = tarArchiveInputStream.getNextEntry();
          entry != null;
-          entry = tarArchiveInputStream.getNextTarEntry()) {
+          entry = tarArchiveInputStream.getNextEntry()) {


While this for loop is correct, it can be simplified into a more idiomatic while loop. This would also make it consistent with other parts of the codebase where TarArchiveInputStream is used (for example, in ReproducibleImageTest.java).

Consider refactoring this loop to:

TarArchiveEntry entry; while ((entry = tarArchiveInputStream.getNextEntry()) != null) { // ... loop body }

magiccrafter · 2025-10-02T09:14:29Z

Could someone please review this and merge it? Thank you.

atrujillofalcon · 2025-10-20T23:02:50Z

Please don't abandon the project

cailliaud · 2025-10-27T12:51:44Z

Thank you @armsargis for the fix.
I can't wait to use it when the ##4427 will be released

ML-Marco · 2025-10-29T11:47:47Z

@armsargis @diegomarquezp
This will not fully support Java 25. In Java 25 a main method is not required to be public any more.

See: https://docs.oracle.com/javase/specs/jls/se25/html/jls-12.html#jls-12.1.4

It has a single formal parameter (§8.4.1) whose declared type is an array of String, a void result, and public, protected or package access

This should be changed as well:

jib/jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java

Lines 126 to 135 in 87b4c0e

    
             public MethodVisitor visitMethod( 
        
                 int access, String name, String descriptor, String signature, String[] exceptions) { 
        
               if ((access & ~OPTIONAL_ACCESS) == (Opcodes.ACC_PUBLIC | Opcodes.ACC_STATIC) 
        
                   && name.equals("main") 
        
                   && descriptor.equals(MAIN_DESCRIPTOR)) { 
        
                 visitedMainClass = true; 
        
               } 
        
               return null; 
        
             } 
        
           }

A main class can now look like this:

void main() {
    System.out.println("Hello, World!");
}

More details can also be found in JEP 512

Also, asm 9.9 is out by now and should be used.

breun · 2025-10-29T12:59:21Z

@ML-Marco Since this pull request is already merged and closed, it might be a good idea to create a new issue (and optionally a pull request?) for adding support for the additional main method variants that Java 25 supports, and maybe a separate issue to update to ASM 9.9 is also a good idea.

I believe this pull request should already support existing code bases that upgrade to Java 25 from a previous Java version.

diegomarquezp · 2025-10-29T14:13:34Z

Hi @ML-Marco. We do plan to support JEP 512 with the next release. As @breun mentioned, we will first make sure this supports upgrades to JDK 25.

ML-Marco · 2025-10-29T14:27:13Z

@diegomarquezp
I opened a pr for it #4432
Maybe this can be included in the release.

Replace deprecated getNextTarEntry with getNextEntry and updated …

1d6bfe9

…`org.ow2.asm:asm` to version 9.8.

gemini-code-assist bot reviewed Sep 22, 2025

View reviewed changes

loicgreffier mentioned this pull request Oct 4, 2025

Upgrade to Java 25 loicgreffier/spring-boot-kafka-quickstarts#151

Closed

breun mentioned this pull request Oct 23, 2025

Support java 25 #4417

Closed

Merge branch 'master' into jib-core-java-25

27127e9

diegomarquezp added the kokoro:force-run label Oct 24, 2025

kokoro-team removed the kokoro:force-run label Oct 24, 2025

diegomarquezp approved these changes Oct 24, 2025

View reviewed changes

diegomarquezp merged commit 87b4c0e into GoogleContainerTools:master Oct 24, 2025
6 of 7 checks passed

thetric mentioned this pull request Oct 24, 2025

JIB Maven not supporting JDK 24 #4397

Open

nhmarujo mentioned this pull request Oct 24, 2025

Upgrade ASM to 9.6 to support Java 22 #4220

Open

diegomarquezp changed the title ~~Updated org.ow2.asm:asm to version 9.8 for java 25 support~~ Update org.ow2.asm:asm to version 9.8 for java 25 support Oct 27, 2025

ML-Marco mentioned this pull request Oct 29, 2025

Fully support Java 25 and its flexible main methods #4431

Closed

diegomarquezp changed the title ~~Update org.ow2.asm:asm to version 9.8 for java 25 support~~ deps: update org.ow2.asm:asm to version 9.8 for java 25 support Nov 17, 2025

deps: update org.ow2.asm:asm to version 9.8 for java 25 support #4418

deps: update org.ow2.asm:asm to version 9.8 for java 25 support #4418

Uh oh!

Conversation

armsargis commented Sep 22, 2025 • edited by diegomarquezp Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Sep 22, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot commented Sep 22, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot commented Sep 22, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

magiccrafter commented Oct 2, 2025

Uh oh!

atrujillofalcon commented Oct 20, 2025

Uh oh!

Uh oh!

cailliaud commented Oct 27, 2025

Uh oh!

ML-Marco commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

breun commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

diegomarquezp commented Oct 29, 2025

Uh oh!

ML-Marco commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support #4418

deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support #4418

armsargis commented Sep 22, 2025 •

edited by diegomarquezp

Loading

ML-Marco commented Oct 29, 2025 •

edited

Loading

breun commented Oct 29, 2025 •

edited

Loading