tgc-revival: Refactor FindIdentityParams to use multi-segment logical AND matching#5322
Merged
modular-magician merged 1 commit intoGoogleCloudPlatform:mainfrom Mar 20, 2026
Conversation
… AND matching (#16762) [upstream:4191ccc585829e0e8ca84c7155960fae2b225a09] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit f119009
into
GoogleCloudPlatform:main
4 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
FindIdentityParamsfunction within the TGC generator attempted to identify a single uniquely distinguishing URL path segment (IdentityParam) to differentiate between Terraform resources that share the exact same CAI asset type.However, this naive approach fails on complex resource groupings like
compute.googleapis.com/FirewallPolicy, where resources likeNetworkFirewallPolicyandRegionNetworkFirewallPolicyshare parameters globally and regionally, meaning they require a combination of path segments (e.g., "projects" AND "global") to be reliably identified.This PR completely refactors the identity parsing logic to aggressively group all identifying segments together rather than isolating just one.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#16762