Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping up sqlServer Image to fix issue of permission denied on /proc/pid/task #916

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

VardhanThigle
Copy link
Collaborator

@VardhanThigle VardhanThigle commented Oct 7, 2024

Bumping up sqlServer Image to fix issue of permission denied on /proc/pid/task

Fixes: Failure in integration tests.
Summary of Issue: SqlServer initialization fails with permission denied on /pdoc/pid/task. As per /mssql-docker/issues/538, it's recommended to bump up the base ubuntu version of the docker image.

Reference: microsoft/mssql-docker#538

  • Tests pass - Successful a run of integration tests.
  • Appropriate changes to README are included in PR - NA

@VardhanThigle VardhanThigle requested a review from a team as a code owner October 7, 2024 07:08
@VardhanThigle VardhanThigle requested review from bharadwaj-aditya and shreyakhajanchi and removed request for a team October 7, 2024 07:08
@VardhanThigle VardhanThigle marked this pull request as draft October 7, 2024 07:08
@VardhanThigle VardhanThigle changed the title Bumping up sqlServer Image to fix issue of permission denied on /proc… [Draft] Bumping up sqlServer Image to fix issue of permission denied on /proc/pid/task Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.13%. Comparing base (fd1825a) to head (8498f9a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   46.48%   46.13%   -0.36%     
==========================================
  Files         166      166              
  Lines       21908    21908              
  Branches      515      515              
==========================================
- Hits        10185    10108      -77     
- Misses      11175    11220      +45     
- Partials      548      580      +32     
Components Coverage Δ
backend-apis 45.36% <ø> (ø)
backend-library 52.23% <ø> (ø)
cli 5.14% <ø> (ø)
frontend 33.95% <ø> (-2.04%) ⬇️

see 28 files with indirect coverage changes

@VardhanThigle VardhanThigle force-pushed the fixing-it branch 8 times, most recently from 1522310 to 6a0b2c8 Compare October 7, 2024 08:23
@VardhanThigle VardhanThigle changed the title [Draft] Bumping up sqlServer Image to fix issue of permission denied on /proc/pid/task Bumping up sqlServer Image to fix issue of permission denied on /proc/pid/task Oct 7, 2024
@Deep1998
Copy link
Collaborator

Deep1998 commented Oct 7, 2024

LGTM, thanks for the fix.

@VardhanThigle VardhanThigle marked this pull request as ready for review October 7, 2024 09:10
@VardhanThigle VardhanThigle merged commit f4d0319 into master Oct 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants