Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Value Pop up Warning #889

Open
wants to merge 2 commits into
base: feature/default-value
Choose a base branch
from
Open

Default Value Pop up Warning #889

wants to merge 2 commits into from

Conversation

NirnayaSindhuSuthari
Copy link
Contributor

@NirnayaSindhuSuthari NirnayaSindhuSuthari commented Jul 25, 2024 •
edited
Loading

  • Default Values are migrated only when Spanner Configuration Details are provided.
  • A pop up warning is given after clicking on "Connect" button only when Spanner Configuration Details are not provided.
  • Pop up warning has two choices with a warning message, either to "Cancel" or "Continue".
  • Clicking on "Cancel" , user will stay on same page to provide Spanner Configuration Details.
  • Clicking on "Continue", user will be taken to workspace page without any Default Values for spanner database.
  • Pop up warning image
    image
  • Image of workspace when spanner configuration details are not provided (after clicking "Continue")
    image
  • Image of workspace when spanner configuration details are provided
    image

@NirnayaSindhuSuthari NirnayaSindhuSuthari requested a review from a team as a code owner July 25, 2024 03:05
@NirnayaSindhuSuthari NirnayaSindhuSuthari requested review from VardhanThigle and bharadwaj-aditya and removed request for a team July 25, 2024 03:05
darshan-sj
darshan-sj reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add screenshots in the description.

asthamohta
asthamohta reviewed Aug 7, 2024
View reviewed changes
ui/src/app/components/direct-connection/direct-connection.component.ts
@@ -103,6 +113,24 @@ export class DirectConnectionComponent implements OnInit {
})
}

checkSpConfig() {
if (this.isOfflineStatus) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshan-sj darshan-sj darshan-sj left review comments

@asthamohta asthamohta asthamohta left review comments

@VardhanThigle VardhanThigle Awaiting requested review from VardhanThigle VardhanThigle is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@bharadwaj-aditya bharadwaj-aditya Awaiting requested review from bharadwaj-aditya bharadwaj-aditya is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NirnayaSindhuSuthari @darshan-sj @asthamohta