Integration test for Foreign Key Action Migration Feature #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasthabharill
requested review from
Deep1998 and
bharadwaj-aditya
and removed request for
a team
…abharill/spanner-migration-tool into integration-test-fkactions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 46.06% 46.06% -0.01%
==========================================
Files 166 166
Lines 21704 21704
Branches 515 515
==========================================
- Hits 9999 9997 -2
- Misses 11136 11138 +2
Partials 569 569
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests for MySQL and PostgreSQL are added for direct database connection and dumpfile to check if foreign key actions are being translated to Spanner dialects correctly.
The translated Spanner database is queried and a row in the parent table is deleted. Then the child row can be checked for the appropriate action - in case of ON DELETE NO ACTION, both the parent and child row should be retained and deletion should fail, and for ON DELETE CASCADE, the child row should be automatically deleted after deletion of the parent row