FK Actions: Handling interleaving & dropping issues correctly when dropping FKs #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…harill/spanner-migration-tool into tests-warnings-fkactions
…harill/spanner-migration-tool into tests-warnings-fkactions
Deep1998
reviewed
Jul 17, 2024
|
Overall LGTM, please resolve Shreya's comments before merging. Thanks for the changes, this was a rather tricky scenario handling interleaved tables and the issue management. |
Deep1998
reviewed
Jul 19, 2024
Deep1998
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interleaving support:
a. Propagate foreign key action to interleaved table from foreign key
b. Ensure DDL generated includes on delete action
Major Changes: Instead of storing parentId as string in Conv, it now stores ParentTable struct containing parent id and on delete action.
Drop issues when foreign key is dropped
a. Foreign key actions added TableLevelIssues to SchemaIssues of Conv that need to be dropped (both internally and from UI and reports) when foreign key is dropped, while ensuring warnings raised by other FKs remain intact
Unit test coverage added to all code changes (Primarily testing fk->interleaved action migration and SchemaIssues)