fix: deprecate input file pattern #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asthamohta
requested review from
shreyakhajanchi and
aksharauke
and removed request for
a team
manitgupta
reviewed
Jun 19, 2024
There was a problem hiding this comment.
So if the inputFilePattern is removed and the gcsPubSubSubscription is made mandatory, any customer reliant oninputFilePattern is already gonna break given gcsPubSubSubscription is mandatory now.
This means they will have to update how they are running. If they are updating, they can remove inputFilePattern as well. This should mean we can just remove this parameter altogether from the template instead of marking it as deprecated.
What am I missing? @darshan-sj / @asthamohta
manitgupta
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.