Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming go sample test #752

Closed

Conversation

manitgupta
Copy link
Member

  • Provides a sample test for streaming go with minimally invasive changes to test the LaunchDataflowJob function.
  • It does not refactor the whole file, just adds a unit test for the specified public method.
  • It mocks out the Dataflow and Datastream client external API calls.
  • It can be said with a high degree of confidence that these changes are not breaking and most likely will not cause a regression.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #752 (a3490ed) into master (e323330) will increase coverage by 0.41%.
Report is 2 commits behind head on master.
The diff coverage is 42.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
+ Coverage   46.06%   46.47%   +0.41%     
==========================================
  Files         122      122              
  Lines       17120    17123       +3     
  Branches      471      471              
==========================================
+ Hits         7886     7958      +72     
+ Misses       8739     8661      -78     
- Partials      495      504       +9     
Components Coverage Δ
backend-apis 43.33% <ø> (ø)
backend-library 53.51% <42.30%> (+0.71%) ⬆️
cli 0.00% <ø> (ø)
frontend 32.08% <ø> (+0.11%) ⬆️
Files Coverage Δ
streaming/streaming.go 18.47% <42.30%> (+9.93%) ⬆️

... and 1 file with indirect coverage changes

@manitgupta manitgupta closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant